feat: sctp connection using usrsctp #11
Open
+751
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Comment on lines
+9
to
+12
| let udp = UdpTransport.new(laddr) | ||
| let stun = Stun.new(udp) | ||
| let dtls = Dtls.new(stun) | ||
| let sctp = Sctp.new(dtls) |
There was a problem hiding this comment.
If the final instance that matter is sctp, maybe we could just have something like Sctp.new(laddr)?
| let sctp = Sctp.new(dtls) | ||
|
|
||
| let conn = await sctp.connect(initTAddress("127.0.0.1:4242"), sctpPort = 13) | ||
| while true: |
There was a problem hiding this comment.
We could do this only a few times, maybe 10?
| import ../webrtc/sctp/[sctp_transport, sctp_connection] | ||
|
|
||
| proc main() {.async.} = | ||
| let laddr = initTAddress("127.0.0.1:4244") |
There was a problem hiding this comment.
why do we fix a local address?
|
|
||
| asyncTest "Two SCTP nodes connecting to each other, then sending/receiving data": | ||
| var | ||
| sctpServer = initSctpStack(initTAddress("127.0.0.1:4444")) |
There was a problem hiding this comment.
It's better to use 0 port to avoid errors with port reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presentation
This PR is part of the stack to create the nim-libp2p webrtc-direct transport (defined here: https://github.com/libp2p/specs/blob/master/webrtc/webrtc-direct.md).
For this PR, we do not implement the full SCTP protocol, we are using the library usrsctp (nim wrapper: https://github.com/status-im/nim-usrsctp / C-library https://github.com/sctplab/usrsctp) to create and use SCTP channels.
SCTP
Stream Control Transmission Protocol (SCTP) is a transport-layer protocol used for transmitting multiple streams of data simultaneously between two endpoints, ensuring reliable, ordered delivery of messages. In the WebRTC stack, SCTP is employed to handle data channels, providing a reliable and unordered delivery of messages, which is critical for real-time communication applications. This allows WebRTC to efficiently transmit diverse types of data, such as text messages, file transfers, or application data, ensuring smooth and reliable communication between peers.